[ 
https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514884
 ] 

Hoss Man commented on SOLR-256:
-------------------------------

Hmmm... some quick poking around makes it seem that tomcat always uses 
MBeanServers to manage things -- regardless of whether you explicitly turn on 
JMX monitoring or not (there seems to be an assumption that of course you want 
to monitor you server -- i can't really argue with that)

i don't really know enough about JMX to know if there really is any sort of 
overhead here -- i suppose it wouldn't hurt to only use the MOnitoredMap if an 
explicit option is set (but we shouldn't startup our own MBeanServer like hte 
orriginal patch -- just use the main one)  but i'm also fine committing the 
patch as is. 

any tomcat/jmx experts want to chime in here?

> Stats via JMX
> -------------
>
>                 Key: SOLR-256
>                 URL: https://issues.apache.org/jira/browse/SOLR-256
>             Project: Solr
>          Issue Type: New Feature
>          Components: search, update
>            Reporter: Sharad Agarwal
>            Priority: Minor
>         Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes. 
> In SolrInfoRegistry, I have overloaded Map's  put and remove methods to 
> register and unregister SolrInfoMBean in MBeanServer. 
> Later on, I am planning to use register and unregister methods in 
> SolrInfoRegistry and removing getRegistry() method (Hiding the map instance 
> to other classes)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to