[ 
https://issues.apache.org/jira/browse/SOLR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517674
 ] 

Paul Sundling commented on SOLR-326:
------------------------------------

I just ran ant clean javadoc and it had 14 errors (not bad for a code base of 
this size!).  Although my patch touches a lot of classes, none of them were 
classes I touched (judging from the '>' I see in subversive eclipse plugin for 
files that were modified.

I think Eclipse is smart enough and I've seen it add imports when I add 
annotations.  I don't use @see in javadocs that often.  Let me know if you see 
different behavior.  I reverted my changes locally and still had the same 14 
javadoc errors.  So I'm pretty confident that I didn't introduce errors in the 
patch.

> cleanup eclipse warnings
> ------------------------
>
>                 Key: SOLR-326
>                 URL: https://issues.apache.org/jira/browse/SOLR-326
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Paul Sundling
>            Priority: Minor
>         Attachments: remove_unused_imports_patch.txt
>
>
> On default settings, Eclipse had 628 warnings.  This patch removes 119 of 
> those warnings related to unused imports.  These are the safest warnings to 
> fix and shouldn't require any testing other than confirming building still 
> works.  
> The general idea of removing warnings is both cleaner code, but also making 
> it easier for interesting warnings to get hidden by uninteresting warnings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to