[
https://issues.apache.org/jira/browse/SOLR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518894
]
Ryan McKinley commented on SOLR-326:
------------------------------------
It is three click process from source > cleanup to remove the unused imports,
so keeping this up to date is easy ;)
In general, I think it is discouraged to change code unless there is something
wrong with it.... that said, I would like to see fewer warnings in eclipse. I
would also like to see the @Override annotation on overridden methods.
Unless there are objections, I will commit changes that remove unused imports
and add the @Override annotation in the next few days...
> cleanup eclipse warnings
> ------------------------
>
> Key: SOLR-326
> URL: https://issues.apache.org/jira/browse/SOLR-326
> Project: Solr
> Issue Type: Improvement
> Reporter: Paul Sundling
> Priority: Minor
> Attachments: remove_unused_imports_patch.txt
>
>
> On default settings, Eclipse had 628 warnings. This patch removes 119 of
> those warnings related to unused imports. These are the safest warnings to
> fix and shouldn't require any testing other than confirming building still
> works.
> The general idea of removing warnings is both cleaner code, but also making
> it easier for interesting warnings to get hidden by uninteresting warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
