On Nov 19, 2007 10:26 PM, Chris Hostetter <[EMAIL PROTECTED]> wrote:
> Last time i looked at most usages, the getOffset() and getCount() were
> totally ignored
Not any more... see QueryComponent.process():
results.docList = searcher.getDocList(
builder.getQuery(), builder.getFilters(),
builder.getSortSpec().getSort(),
builder.getSortSpec().getOffset(), builder.getSortSpec().getCount(),
builder.getFieldFlags() );
> A quick grep indicates that the new QParser and QueryComponent stuff
> (which i still haven't had time to look at) seems to be using it, but i
> can't tell if that's just because that's what's parseSort returns, or if
> it's becuse it's actually useful to have those three values bundled in
> that way.
I think it does make sense to keep them together.
offset and length only make sense if an ordering is specified.
> if we're going to keep it, let's at least put some mutators on it ... and
> maybe consider changing the name.
If we change the name, we should also move it to a top-level class
(from a static inner).
Any suggestions?
-Yonik
