[
https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594136#action_12594136
]
Ryan McKinley commented on SOLR-560:
------------------------------------
I attached a quick patch to convert to SLF4j. I have not fully tested to make
sure the default behavior is the same as it was before, but a quick look at the
example seems reasonable.
This changed:
log.finest -> log.trace
log.fine -> log.debug
log.warning -> log.warn
log.severe -> log.error
(info stays the same)
The only bit I was not sure how to translate is in SolrRequestParsers.java:
{code:java}
log.throwing(getClass().getName(), "getTransformer", tce);
{code}
for now, i just used:
{code:java}
log.error( getClass().getName() + " getTransformer", tce );
{code}
Additionally, wherever I noticed it, I used slf4j style "formatters":
http://www.slf4j.org/faq.html#logging_performance
but we may want to make a more through review
> Convert JDK logging to SLF4J
> ----------------------------
>
> Key: SOLR-560
> URL: https://issues.apache.org/jira/browse/SOLR-560
> Project: Solr
> Issue Type: Wish
> Reporter: Ryan McKinley
> Fix For: 1.3
>
> Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar,
> SOLR-560-slf4j.patch
>
>
> After lots of discussion, we should consider using SLF4j to enable more
> flexibility in logging configuration.
> See:
> http://www.nabble.com/Solr-Logging-td16836646.html
> http://www.nabble.com/logging-through-log4j-td13747253.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
