[ 
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606810#action_12606810
 ] 

Yonik Seeley commented on SOLR-502:
-----------------------------------

bq. I think that makes sense, but seems to be a big change to add to this patch.

The patch already changes (or adds to) the API.  So instead of passing down 
extra parameters (timeout and NamedList), pass down an object that encapsulates 
all the parameters.  Deprecations can wait for another day.

The primary motivation is that it seems messy passing down the un-typed 
NamedList<Object> and having SolrIndexSearcher set things in the header (rather 
than the QueryComponent do it).

> Add search time out support
> ---------------------------
>
>                 Key: SOLR-502
>                 URL: https://issues.apache.org/jira/browse/SOLR-502
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Sean Timm
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, 
> SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, 
> solrTimeout.patch, solrTimeout.patch, solrTimeout.patch
>
>
> Uses LUCENE-997 to add time out support to Solr.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to