[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621867#action_12621867
]
henrib edited comment on SOLR-647 at 8/12/08 10:13 AM:
--------------------------------------------------------------
Grant,
bq.At a minimum, all that should be documented
I'll adapt the previous comments accordingly to make the Javadoc more obvious.
bq. the MultiCoreHandler uses getCore() in places, while the SolrDispatchFilter
uses the Reference
Good catch; the admin core (the one used to generate output) is protected but
is this enough?
The MultiCoreHandler only deals with CoreDescriptor (not SolrCore); it does not
perform "real" queries although getStatus comes close to it.
However, it would seem preferable to avoid manipulating the (multicore) cores
map while we are are processing such requests.
I'll fix it in the next upload.
Thanks for reviewing this.
was (Author: henrib):
Grant,
bq.At a minimum, all that should be documented
I'll adapt the previous comments accordingly.
bq. the MultiCoreHandler uses getCore() in places, while the SolrDispatchFilter
uses the Reference
Good catch; the admin core is protected but not the targeted core... I'll fix
it in the next upload.
Thanks for reviewing this.
> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
> Key: SOLR-647
> URL: https://issues.apache.org/jira/browse/SOLR-647
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause
> Exceptions for in-flight requests. The _close()_ method should just do a
> decrement on refcount and the actual close must happen when the last request
> being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
