[
https://issues.apache.org/jira/browse/SOLR-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622561#action_12622561
]
Shalin Shekhar Mangar commented on SOLR-700:
--------------------------------------------
This is great, thanks Stefan!
IMO, one JIRA issue should deal with one task. Do you mind opening another
issue for the DateField and LegacyDateField bug and attach it's patch there? I
shall commit your NumberFormatTransformer enhancement patch, edit this issue's
description and update the wiki docs.
> test failures because of wrong/unexpected locale
> ------------------------------------------------
>
> Key: SOLR-700
> URL: https://issues.apache.org/jira/browse/SOLR-700
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Stefan Oestreicher
> Priority: Minor
> Attachments:
> handler.dataimport.NumberFormatTransformer-locale.patch..txt,
> handler.dataimport.NumberFormatTransformer-locale.patch..txt,
> handler.dataimport.NumberFormatTransformer-locale.patch..txt,
> handler.dataimport.NumberFormatTransformer-locale.patch..txt,
> handler.dataimport.TestNumberFormatTransformer-locale.patch.txt,
> schema.DateField-locale.patch.txt
>
>
> The following unit tests fail if they're run with a german locale:
> org.apache.solr.schema.LegacyDateFieldTest
> org.apache.solr.schema.DateFieldTest
> org.apache.solr.handler.dataimport.TestNumberFormatTransformer
> The DateField tests fail because the expected decimal format uses "." as
> separator but the actual result is formatted using the "," separator.
> This happens because the ISO8601CanonicalDateFormat class which is defined
> inside the DateField class doesn't specify the US locale when creating the
> formatter used for milliseconds.
> Patch: schema.DateField-locale.patch.txt
> TestNumberFormatTransformer failed because
> handler.dataimport.NumberFormatTransformer uses a NumberFormatter which
> relies on the system locale. But I think in this case it's intentional, so I
> modified the test case to use the grouping separator of the system locale.
> Patch: handler.dataimport.TestNumberFormatTransformer-locale.patch.txt
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
