[ 
https://issues.apache.org/jira/browse/SOLR-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-700:
---------------------------------------

    Attachment: SOLR-700.patch

A new patch (SOLR-700.patch) based on Stefan's work with the following changes:
# Changed the locale parsing code to use pre-compiled regex.
# Throw an exception if an invalid value (which does not match the regex) is 
specified. Interestingly, the java.util.Locale class's docs do not say anything 
about invalid language or countries.
# Modified TestNumberFormatTransformer to demonstrate the fix and enhancement.

I will commit this shortly.

> NumberFormatTransformer should have configurable locales
> --------------------------------------------------------
>
>                 Key: SOLR-700
>                 URL: https://issues.apache.org/jira/browse/SOLR-700
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Stefan Oestreicher
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: 
> handler.dataimport.NumberFormatTransformer-locale.patch..txt, 
> handler.dataimport.NumberFormatTransformer-locale.patch..txt, 
> handler.dataimport.NumberFormatTransformer-locale.patch..txt, 
> handler.dataimport.NumberFormatTransformer-locale.patch..txt, 
> handler.dataimport.TestNumberFormatTransformer-locale.patch.txt, 
> schema.DateField-locale.patch.txt, SOLR-700.patch
>
>
> NumberFormatTransformer uses a NumberFormatter which relies on the system 
> locale. This makes it impossible to use NumberFormatTransformer with data 
> whose locale does not match the system locale.
> TestNumberFormatTransformer fails on some locales for similar reasons because 
> the grouping symbol differs in different locales.
> This issue adds a locale attribute for NumberFormatTransformer which allows 
> the user to specify the locale which should be used for formatting. The 
> locale must be specified as land-country e.g. en-US
> {code:xml}
> <field column="myNumber" formatStyle="number" locale="de-DE" />
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to