[
https://issues.apache.org/jira/browse/SOLR-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622879#action_12622879
]
Otis Gospodnetic commented on SOLR-538:
---------------------------------------
Lars, do you think you could change those tabs into 2 spaces to follow the code
style convention?
In CopyFieldTest I see things like:
+ try {
+ new CopyField(null,
+ new SchemaField("destination", new
TextField()), 1000);
+ fail("CopyField failed with null SchemaField
argument.");
+ } catch (IllegalArgumentException e) {
+ assertTrue(e.getLocalizedMessage().contains("can't be
NULL"));
Does the assertTrue message really accurately describe the exception? What is
null in the above case? What happens when maxLength="0"? The previous/default
copy-everything behaviour, right? Maybe I missed it, but I didn't see that in
any javadocs or comments or the example schema.xml.
> CopyField maxLength property
> ----------------------------
>
> Key: SOLR-538
> URL: https://issues.apache.org/jira/browse/SOLR-538
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Nicolas Dessaigne
> Priority: Minor
> Attachments: CopyFieldMaxLength.patch, CopyFieldMaxLength.patch,
> SOLR-538.patch
>
>
> As discussed shortly on the mailing list (http://www.mail-archive.com/[EMAIL
> PROTECTED]/msg09807.html), the objective of this task is to add a maxLength
> property to the CopyField "command". This property simply limits the number
> of characters that are copied.
> This is particularly useful to avoid very slow highlighting when the index
> contains big documents.
> Example :
> <copyField source="text" dest="highlight" maxLength="30000" />
> This approach has also the advantage of limiting the index size for large
> documents (the original text field does not need to be stored and to have
> term vectors). However, the index is bigger for small documents...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
