[
https://issues.apache.org/jira/browse/SOLR-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645967#action_12645967
]
Koji Sekiguchi commented on SOLR-538:
-------------------------------------
Thank you for the updated patch. I have some comments.
# I think this breaks back-compat:
{code}
Index: src/java/org/apache/solr/schema/IndexSchema.java
===================================================================
--- src/java/org/apache/solr/schema/IndexSchema.java (revision 712067)
+++ src/java/org/apache/solr/schema/IndexSchema.java (working copy)
:
@@ -654,12 +664,12 @@
*
* @see SolrCoreAware
*/
- public void registerCopyField( String source, String dest )
+ public void registerCopyField( String source, String dest, Integer maxLength
)
{code}
and the type of maxLength is int (not Integer) right?
# Can you use 2-space indentation instead of tab indentation?
# Can you change "@since 1.3" javadoc comments to "@since 1.4"?
# The new attribute "maxLength" may make users confused (number of chars or
tokens?). How about using "maxChars" or something?
> CopyField maxLength property
> ----------------------------
>
> Key: SOLR-538
> URL: https://issues.apache.org/jira/browse/SOLR-538
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Nicolas Dessaigne
> Priority: Minor
> Attachments: CopyFieldMaxLength.patch, CopyFieldMaxLength.patch,
> SOLR-538.patch, SOLR-538.patch, SOLR-538.patch, SOLR-538.patch, SOLR-538.patch
>
>
> As discussed shortly on the mailing list (http://www.mail-archive.com/[EMAIL
> PROTECTED]/msg09807.html), the objective of this task is to add a maxLength
> property to the CopyField "command". This property simply limits the number
> of characters that are copied.
> This is particularly useful to avoid very slow highlighting when the index
> contains big documents.
> Example :
> <copyField source="text" dest="highlight" maxLength="30000" />
> This approach has also the advantage of limiting the index size for large
> documents (the original text field does not need to be stored and to have
> term vectors). However, the index is bigger for small documents...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
