[ 
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Biestro updated SOLR-731:
-------------------------------

    Attachment: solr-731.patch

A patch that fixes this issue.

As a strawman feature, this completely removes the necessity to keep a 
CoreDescriptor in the SolrCore.
For compatibility, CoreContainer.describe() can recreate the CoreDescriptor 
(test case through reload).

Refactoring occuring outside of SolrCore/CoreContainer/CoreDescriptor are 
consequences of reducing public exposures of some methods

> CoreDescriptor.getCoreContainer should not be public
> ----------------------------------------------------
>
>                 Key: SOLR-731
>                 URL: https://issues.apache.org/jira/browse/SOLR-731
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>         Attachments: solr-731.patch
>
>
> For the very same reasons that CoreDescriptor.getCoreProperties did not need 
> to be public (aka SOLR-724)
> It also means the CoreDescriptor ctor should not need a CoreContainer
> The CoreDescriptor is only meant to be describing a "to-be created SolrCore".
> However, we need access to the CoreContainer from the SolrCore now that we 
> are guaranteed the CoreContainer always exists.
> This is also a natural consequence of SOLR-647 now that the CoreContainer is 
> not a map of CoreDescriptor but a map of SolrCore.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to