[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627007#action_12627007
]
Otis Gospodnetic commented on SOLR-731:
---------------------------------------
I've just started looking at CoreDescriptor/CoreContainer. The two (plus
SolrCore) seem quite a bit intertwined, so I think removing the CD -> CC
reference sounds like a simplification.
I don't understand the benefit of removing the SC -> CD reference though, and
on-the-fly reconstruction of core's CD in that describe method.
> CoreDescriptor.getCoreContainer should not be public
> ----------------------------------------------------
>
> Key: SOLR-731
> URL: https://issues.apache.org/jira/browse/SOLR-731
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Henri Biestro
> Attachments: solr-731.patch
>
>
> For the very same reasons that CoreDescriptor.getCoreProperties did not need
> to be public (aka SOLR-724)
> It also means the CoreDescriptor ctor should not need a CoreContainer
> The CoreDescriptor is only meant to be describing a "to-be created SolrCore".
> However, we need access to the CoreContainer from the SolrCore now that we
> are guaranteed the CoreContainer always exists.
> This is also a natural consequence of SOLR-647 now that the CoreContainer is
> not a map of CoreDescriptor but a map of SolrCore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
