[
https://issues.apache.org/jira/browse/SOLR-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627309#action_12627309
]
Eric Pugh commented on SOLR-284:
--------------------------------
So, in typical open source fashion, I wrote the original patch to scratch my
own itch. Which meant that it was okay to make id be hardcoded. However, even
when I first posted the patch to this JIRA issue, I felt a little "icky" about
the id field. It seemed like a code smell to have this magic id! So, from
that standpoint, I think the changes that Chris has posted look great.
I think it's a good example of a patch getting better and better everytime
someone else uses it!
Now, if only this almost 14 month old patch could be applied! With 28 votes,
and 16 active watches, clearly somebody out there finds this useful!
And at this point it is miles better then what I first posted! Keep up the
great work and great contributions back!
> Parsing Rich Document Types
> ---------------------------
>
> Key: SOLR-284
> URL: https://issues.apache.org/jira/browse/SOLR-284
> Project: Solr
> Issue Type: New Feature
> Components: update
> Reporter: Eric Pugh
> Fix For: 1.4
>
> Attachments: libs.zip, rich.patch, rich.patch, rich.patch,
> rich.patch, rich.patch, source.zip, test-files.zip, test-files.zip, test.zip,
> un-hardcode-id.diff
>
>
> I have developed a RichDocumentRequestHandler based on the CSVRequestHandler
> that supports streaming a PDF, Word, Powerpoint, Excel, or PDF document into
> Solr.
> There is a wiki page with information here:
> http://wiki.apache.org/solr/UpdateRichDocuments
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
