[ 
https://issues.apache.org/jira/browse/SOLR-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657087#action_12657087
 ] 

Ryan McKinley commented on SOLR-915:
------------------------------------

I don't see any issue with Collection vs List.

However I still don't see how making closeHook execution parallel helps your 
problem.  close() still returns when the core and all its hooks have closed.

Perhaps you just want to add a single closeHook that starts up a Thead for your 
long running operations?  

> SolrCore;close()  - scope to exploit parallelism among the number of 
> closeHooks 
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-915
>                 URL: https://issues.apache.org/jira/browse/SOLR-915
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>         Environment: Tomcat 6, JRE 6
>            Reporter: Kay Kay
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-915.patch, SOLR-915.patch, SOLR-915.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> In SolrCore: close() - all the way towards the end of the function - there 
> seems to be a sequential list of close method invocation. 
>     if( closeHooks != null ) {
>        for( CloseHook hook : closeHooks ) {
>          hook.close( this );
>       }
>     }
> I believe this has scope to be parallelized ( actually the entire sequence of 
> close operations , updateHandler,close() etc.) - by means of launching them 
> in separate threads from an ExecutorService , for a much faster shutdown as 
> the process definitely does not need to be sequential. 
> This becomes all the more important in the multi-core context when we might 
> want to shutdown and restart a SolrCore altogether. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to