[
https://issues.apache.org/jira/browse/SOLR-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657091#action_12657091
]
Kay Kay commented on SOLR-915:
------------------------------
| I don't see any issue with Collection vs List.
List, by default implies ordering and Collection does not. Making it a
collection is more intuitive since there is really not a specific order ( at
least intuitively) that could be obvious to the programmer . Since - there
could be multiple plugins registering themselves as SolrCoreAware and adding
closeHooks , Hence a Collection intuitively reflects what the underlying use
case is.
| Perhaps you just want to add a single closeHook that starts up a Thead for
your long running operations?
Sure - I could. But I believe by nature of being a closeHook - it should not
interfere with the actual close process , but act as a plugin to the process
that is guaranteed to be notified when the process happens.
> SolrCore;close() - scope to exploit parallelism among the number of
> closeHooks
> --------------------------------------------------------------------------------
>
> Key: SOLR-915
> URL: https://issues.apache.org/jira/browse/SOLR-915
> Project: Solr
> Issue Type: Improvement
> Components: search
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Assignee: Ryan McKinley
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-915.patch, SOLR-915.patch, SOLR-915.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> In SolrCore: close() - all the way towards the end of the function - there
> seems to be a sequential list of close method invocation.
> if( closeHooks != null ) {
> for( CloseHook hook : closeHooks ) {
> hook.close( this );
> }
> }
> I believe this has scope to be parallelized ( actually the entire sequence of
> close operations , updateHandler,close() etc.) - by means of launching them
> in separate threads from an ExecutorService , for a much faster shutdown as
> the process definitely does not need to be sequential.
> This becomes all the more important in the multi-core context when we might
> want to shutdown and restart a SolrCore altogether.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
