[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671409#action_12671409
]
Noble Paul commented on SOLR-993:
---------------------------------
bq.If that is the case then please take a look at patch 993b.
This patch is WRONG. It would not work for the functions namespace. Because
functions implements a custom map. look at
EvaluatorBag.getFunctionsNameSpace(). Moreover ,your version of the
VariableResolverImpl is more expensive and creates more objects. Map.putAll()
is far more expensive because it creates so many Map.Entry and removals are
more costly.
Can you tell me what are you trying to achieve. If you can give me usecases It
may help me solve it better.
vr.removeNamespace(null) is a legacy code can be removed.
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
