[ 
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671719#action_12671719
 ] 

Noble Paul commented on SOLR-993:
---------------------------------

bq.In that case, what about splitting the names that are added as you 
previously suggested, so that "c.d" adds "a.b.c", then "a.b.c.d"?

Take the case of "dataimporter.request" (request parameters) namespace. This 
namespace is very likely to contain parameters with '.' (dot) in that . If I 
add it after splitting the names , how will I remove the namespace 
"dataimporter.request" completely without removing other variables which were 
added with addTonameSpace separately?

I guess we can add the new method addToNamespace with the current semantics. 
The ambiguity may not be really as bad as long as it is documented


> VariableResolverImpl addNamespace overwrites entire namespace instead of 
> adding
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-993
>                 URL: https://issues.apache.org/jira/browse/SOLR-993
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Jared Flatow
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-993.patch, SOLR-993b.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the 
> namespace as overwrite it. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to