[ 
https://issues.apache.org/jira/browse/SOLR-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789833#action_12789833
 ] 

Chris A. Mattmann commented on SOLR-1131:
-----------------------------------------

Hi Grant:

Thanks. Your latest patch omits class-level javadoc I wrote for 
DelegatingFieldType and for the #inform method in SchemaAware.

{code}
+/**
+ * An interface for {...@link FieldType}s that are poly fields, as defined in 
<a
+ * href="http://issues.apache.org/jira/browse/SOLR-1131";>SOLR-1131</a>, so that
+ * poly fields can declare the {...@link FieldType}s of their sub-fields.
+ * 
+ * @since SOLR-1131
+ * 
+ **/
+public interface DelegatingFieldType {
+
+  /**
+   * 
+   * Returns the {...@link FieldType}s of the sub-fields for this poly-field.
+   * 
+   * @return A {...@link List} of {...@link FieldType}s for the sub-fields of 
a poly
+   *         field.
+   */
+  public List<FieldType> getSubTypes();
+}
{code}

{code}
+public interface SchemaAware {
+
+  /**
+   * Informs the {...@link IndexSchema} provided by the <code>schema</code>
+   * parameter of an event (e.g., a new {...@link FieldType} was added, etc.
+   * 
+   * @param schema
+   *          The {...@link IndexSchema} instance that inform of the update to.
+   * 
+   * @since SOLR-1131
+   */
+  public void inform(IndexSchema schema);
+}
{code}

Other than that +1. Thanks for seeing this through to a great patch.

Cheers,
Chris


> Allow a single field type to index multiple fields
> --------------------------------------------------
>
>                 Key: SOLR-1131
>                 URL: https://issues.apache.org/jira/browse/SOLR-1131
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>            Reporter: Ryan McKinley
>            Assignee: Grant Ingersoll
>             Fix For: 1.5
>
>         Attachments: SOLR-1131-IndexMultipleFields.patch, 
> SOLR-1131.Mattmann.121009.patch.txt, SOLR-1131.Mattmann.121109.patch.txt, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch
>
>
> In a few special cases, it makes sense for a single "field" (the concept) to 
> be indexed as a set of Fields (lucene Field).  Consider SOLR-773.  The 
> concept "point" may be best indexed in a variety of ways:
>  * geohash (sincle lucene field)
>  * lat field, lon field (two double fields)
>  * cartesian tiers (a series of fields with tokens to say if it exists within 
> that region)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to