[ 
https://issues.apache.org/jira/browse/SOLR-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791414#action_12791414
 ] 

Yonik Seeley commented on SOLR-1131:
------------------------------------

I'm spot-checking mutiple different patches at this point... but in general, we 
should strive to not expose the complexity further up the type hierarchy, and 
we should not limit what subclasses can do.

isPolyField() returns true if more than one Fieldable *can* be returned from 
createFields()
createFields() is free to return whatever the heck it likes.
And from SchemaField and FieldType's perspective,that's it. Implementation 
details are up to subclasses and we shouldn't add assumptions in base classes.  
There should be *no* concept of subFieldTypes or whatever baked into anything.

So, from Noble's patch: we shouldn't try caching subfields in SchemaField... 
and esp not via "if (type instanceof DelegatingFieldType)"... it really doesn't 
belong there.



> Allow a single field type to index multiple fields
> --------------------------------------------------
>
>                 Key: SOLR-1131
>                 URL: https://issues.apache.org/jira/browse/SOLR-1131
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>            Reporter: Ryan McKinley
>            Assignee: Grant Ingersoll
>             Fix For: 1.5
>
>         Attachments: SOLR-1131-IndexMultipleFields.patch, 
> SOLR-1131.Mattmann.121009.patch.txt, SOLR-1131.Mattmann.121109.patch.txt, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch
>
>
> In a few special cases, it makes sense for a single "field" (the concept) to 
> be indexed as a set of Fields (lucene Field).  Consider SOLR-773.  The 
> concept "point" may be best indexed in a variety of ways:
>  * geohash (sincle lucene field)
>  * lat field, lon field (two double fields)
>  * cartesian tiers (a series of fields with tokens to say if it exists within 
> that region)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to