On Nov 17, 2008, at 2:59 PM, Erik Hatcher wrote:


On Nov 17, 2008, at 2:11 PM, Matthias Epheser wrote:
After we add the SolrQueryResponse to the templates first, we realized that some convenience methods for iterating the result docs, accessing facets etc. would be fine.

The idea was to reuse the existing wrappers (eg. QueryResponse). It makes it much nicer to create templates, because velocity is made to just render things, so code using docsets etc. directly may be very overloaded.

Right, and well understood. What I've put out there is a barebones skeleton, and there are lots of TODOs for these conveniences. I want to get it using SolrJ's API for request/response rather than the more internal stuff we're using now.


I think the 'internal' stuff mode is there because Yonik expressed concern about requiring the conversion of DocList to SolrDocumentList -- since Matthias had already done the work to access docs out of the DocList, I figured we should leave it in, even if I can't imagine using it. (someone may be worried about the performance win of not serializing DocList)

ryan

Reply via email to