2009/10/28 gabriele renzi <rff....@gmail.com>:
> On Tue, Oct 27, 2009 at 3:41 PM, Yonik Seeley
> <yo...@lucidimagination.com> wrote:
>
>>> is there a reason why StreamingUpdateSolrServer does not accept a
>>> connection manager argument as CommonsHttpSolrServer does?
>>
>> I don't see any reason why it shouldn't... can you open a JIRA issue
>> and optionally provide a patch?
>
> great, will do both later today (GMT+1 lunch time :) )

done, I hope I have not done anything stupid. No new tests attached
but old ones still pass and testing an inherited ctor seems moot.

While I'm at it, FindBugs has a few issues with the solr code base (a
few hundreds, but most seem false positives) but it does have a few
concurrency related issues that appear reasonable to me, is it of any
use if I submit patches for those too?


-- 
blog en: http://www.riffraff.info
blog it: http://riffraff.blogsome.com

Reply via email to