> > Valeriy E. Ushakov wrote: > >On Tue, May 12, 2009 at 14:18:16 +0000, Christoph Egger wrote: > > >> struct device * -> device_t, no functional changes intended. > > >Why don't you cmp(1) the objects before and after to verify that? > >"Same object code generated" is, unlike intentions, something > >that can be verified. > > A fair number won't be the same, I would guess half our SCSI > drivers are currently broken. > > Do a search in sys/dev/ic for 'adapt_dev', any driver that casts > this to a softc instead of calling device_private() will crash.
The cast is a bug in drivers which have the device_t/softc split already done. It is harmless for those not yet splitted. Christoph