On Fri, Mar 18, 2016 at 04:29:15PM +0000, Nick Hudson wrote: > On 03/18/16 16:19, Joerg Sonnenberger wrote: > >On Fri, Mar 18, 2016 at 10:52:27AM +0000, Christos Zoulas wrote: > >>In article <20160318030154.gb12...@britannica.bec.de>, > >>Joerg Sonnenberger <jo...@britannica.bec.de> wrote: > >>>On Thu, Mar 10, 2016 at 07:44:57PM -0500, Christos Zoulas wrote: > >>>>Module Name: src > >>>>Committed By: christos > >>>>Date: Fri Mar 11 00:44:56 UTC 2016 > >>>> > >>>>Modified Files: > >>>> src/sys/sys: cdefs_elf.h > >>>> > >>>>Log Message: > >>>>Undo weak here to fix the tests; will revisit soon. > >>>Can you revert this now as it is broken and should not be used to work > >>>around binutils bugs? > >>Did something change? If I revert it all the rump tests fail... > >So we are breaking clang for bugs in binutils now? > > > >Joerg > > > > Is there a PR that describes the clang problem?
I gave you a detailed explination why the old version is a problem. So far I have seen no real justification for the change, other than some mumblings about ld mishandling weak symbols. That seems to be a pretty clear cut case for a revert and going back to the design board to understand why rump started failing with new binutils. Joerg
