> On Sep 28, 2021, at 10:58 PM, matthew green <m...@eterna.com.au> wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By: thorpej >> Date: Wed Sep 29 02:47:22 UTC 2021 >> >> Modified Files: >> src/sys/kern: sys_select.c uipc_socket.c >> src/sys/miscfs/fifofs: fifo_vnops.c >> src/sys/sys: select.h >> >> Log Message: >> - Change selremove_knote() from returning void to bool, and return >> true if the last knote was removed and there are no more knotes >> on the selinfo. >> - Use this new return value in filt_sordetach(), filt_sowdetach(), >> filt_fifordetach(), and filt_fifowdetach() to know when to clear >> SB_KOTE without having to know select/kqueue implementation details. > > kernel bump? it's certainly used in modules, but it's not > clear that it would break anything..
Not needed in this case. No callers that need the return value are in a module. -- thorpej