Module Name: src
Committed By: nakayama
Date: Sat Oct 17 08:50:49 UTC 2009
Modified Files:
src/sys/arch/sparc64/include: userret.h
src/sys/arch/sparc64/sparc64: trap.c
Log Message:
Merge want_ast check in userret() into trap handler, and repeat
preempt() call while want_resched is true. While there remove
unnecessary #if 1.
This should fix a performance degradation of disk I/O on heavy load.
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/arch/sparc64/include/userret.h
cvs rdiff -u -r1.157 -r1.158 src/sys/arch/sparc64/sparc64/trap.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/sparc64/include/userret.h
diff -u src/sys/arch/sparc64/include/userret.h:1.8 src/sys/arch/sparc64/include/userret.h:1.9
--- src/sys/arch/sparc64/include/userret.h:1.8 Mon Jun 30 14:12:20 2008
+++ src/sys/arch/sparc64/include/userret.h Sat Oct 17 08:50:49 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: userret.h,v 1.8 2008/06/30 14:12:20 nakayama Exp $ */
+/* $NetBSD: userret.h,v 1.9 2009/10/17 08:50:49 nakayama Exp $ */
/*
* Copyright (c) 1996-2002 Eduardo Horvath. All rights reserved.
@@ -63,14 +63,6 @@
mi_userret(l);
- if (want_ast) {
- want_ast = 0;
- if (l->l_pflag & LP_OWEUPC) {
- l->l_pflag &= ~LP_OWEUPC;
- ADDUPROF(l);
- }
- }
-
/*
* If profiling, charge recent system time to the trapped pc.
*/
Index: src/sys/arch/sparc64/sparc64/trap.c
diff -u src/sys/arch/sparc64/sparc64/trap.c:1.157 src/sys/arch/sparc64/sparc64/trap.c:1.158
--- src/sys/arch/sparc64/sparc64/trap.c:1.157 Sat May 16 19:15:34 2009
+++ src/sys/arch/sparc64/sparc64/trap.c Sat Oct 17 08:50:49 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: trap.c,v 1.157 2009/05/16 19:15:34 nakayama Exp $ */
+/* $NetBSD: trap.c,v 1.158 2009/10/17 08:50:49 nakayama Exp $ */
/*
* Copyright (c) 1996-2002 Eduardo Horvath. All rights reserved.
@@ -50,7 +50,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: trap.c,v 1.157 2009/05/16 19:15:34 nakayama Exp $");
+__KERNEL_RCSID(0, "$NetBSD: trap.c,v 1.158 2009/10/17 08:50:49 nakayama Exp $");
#include "opt_ddb.h"
#include "opt_multiprocessor.h"
@@ -608,12 +608,14 @@
#endif
case T_AST:
-#if 1
- if (want_resched)
+ if (l->l_pflag & LP_OWEUPC) {
+ l->l_pflag &= ~LP_OWEUPC;
+ ADDUPROF(l);
+ }
+ while (want_resched)
preempt();
want_ast = 0;
-#endif
- break; /* the work is all in userret() */
+ break;
case T_ILLINST:
case T_INST_EXCEPT:
