Module Name:    src
Committed By:   msaitoh
Date:           Wed May  1 12:31:51 UTC 2019

Modified Files:
        src/sys/dev/pci: if_alc.c

Log Message:
 Fix a wrong and extra ether_ioctl() call in alc_ioctl(). _IOWR types call
broke ifreq by the first ether_ioct() and the second ether_ioctl() caused
unexpected behavior. One of bug example is that SIOCGIFMEDIA always failed.
This bug was added in if_alc.c rev. 1.16.

XXX pullup-8


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/pci/if_alc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/pci/if_alc.c
diff -u src/sys/dev/pci/if_alc.c:1.32 src/sys/dev/pci/if_alc.c:1.33
--- src/sys/dev/pci/if_alc.c:1.32	Mon Apr 22 09:08:14 2019
+++ src/sys/dev/pci/if_alc.c	Wed May  1 12:31:51 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: if_alc.c,v 1.32 2019/04/22 09:08:14 msaitoh Exp $	*/
+/*	$NetBSD: if_alc.c,v 1.33 2019/05/01 12:31:51 msaitoh Exp $	*/
 /*	$OpenBSD: if_alc.c,v 1.1 2009/08/08 09:31:13 kevlo Exp $	*/
 /*-
  * Copyright (c) 2009, Pyun YongHyeon <[email protected]>
@@ -2054,7 +2054,6 @@ alc_ioctl(struct ifnet *ifp, u_long cmd,
 
 	s = splnet();
 
-	error = ether_ioctl(ifp, cmd, data);
 	switch (cmd) {
 	case SIOCSIFADDR:
 		ifp->if_flags |= IFF_UP;

Reply via email to