CVS commit: src/sys

[Maxime Villard]

Module Name:    src
Committed By:   maxv
Date:           Fri Dec  6 07:27:07 UTC 2019

Modified Files:
        src/sys/dev/acpi: acpi_pci_link.c
        src/sys/dev/pci: auich.c
        src/sys/kern: uipc_mbuf.c

Log Message:
Minor changes, reported by the LGTM bot.


To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/acpi/acpi_pci_link.c
cvs rdiff -u -r1.157 -r1.158 src/sys/dev/pci/auich.c
cvs rdiff -u -r1.235 -r1.236 src/sys/kern/uipc_mbuf.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/sys/dev/acpi/acpi_pci_link.c
diff -u src/sys/dev/acpi/acpi_pci_link.c:1.23 src/sys/dev/acpi/acpi_pci_link.c:1.24
--- src/sys/dev/acpi/acpi_pci_link.c:1.23	Sun Nov 10 21:16:34 2019
+++ src/sys/dev/acpi/acpi_pci_link.c	Fri Dec  6 07:27:06 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: acpi_pci_link.c,v 1.23 2019/11/10 21:16:34 chs Exp $	*/
+/*	$NetBSD: acpi_pci_link.c,v 1.24 2019/12/06 07:27:06 maxv Exp $	*/
 
 /*-
  * Copyright (c) 2002 Mitsuru IWASAKI <iwas...@jp.freebsd.org>
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: acpi_pci_link.c,v 1.23 2019/11/10 21:16:34 chs Exp $");
+__KERNEL_RCSID(0, "$NetBSD: acpi_pci_link.c,v 1.24 2019/12/06 07:27:06 maxv Exp $");
 
 #include <sys/param.h>
 #include <sys/malloc.h>
@@ -116,8 +116,8 @@ struct link {
 	int	l_references;
 	int	l_dev_count;
 	pcitag_t *l_devices;
-	int	l_routed:1;
-	int	l_isa_irq:1;
+	u_int	l_routed:1;
+	u_int	l_isa_irq:1;
 	ACPI_RESOURCE l_prs_template;
 };
 

Index: src/sys/dev/pci/auich.c
diff -u src/sys/dev/pci/auich.c:1.157 src/sys/dev/pci/auich.c:1.158
--- src/sys/dev/pci/auich.c:1.157	Sat Jun  8 08:02:38 2019
+++ src/sys/dev/pci/auich.c	Fri Dec  6 07:27:07 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: auich.c,v 1.157 2019/06/08 08:02:38 isaki Exp $	*/
+/*	$NetBSD: auich.c,v 1.158 2019/12/06 07:27:07 maxv Exp $	*/
 
 /*-
  * Copyright (c) 2000, 2004, 2005, 2008 The NetBSD Foundation, Inc.
@@ -111,7 +111,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: auich.c,v 1.157 2019/06/08 08:02:38 isaki Exp $");
+__KERNEL_RCSID(0, "$NetBSD: auich.c,v 1.158 2019/12/06 07:27:07 maxv Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -215,7 +215,7 @@ struct auich_softc {
 	/* 440MX workaround */
 	int  sc_dmamap_flags;
 	/* flags */
-	int  sc_iose	:1,
+	u_int  sc_iose	:1,
 		     	:31;
 
 	/* sysctl */

Index: src/sys/kern/uipc_mbuf.c
diff -u src/sys/kern/uipc_mbuf.c:1.235 src/sys/kern/uipc_mbuf.c:1.236
--- src/sys/kern/uipc_mbuf.c:1.235	Sat Oct 19 06:36:47 2019
+++ src/sys/kern/uipc_mbuf.c	Fri Dec  6 07:27:07 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: uipc_mbuf.c,v 1.235 2019/10/19 06:36:47 tnn Exp $	*/
+/*	$NetBSD: uipc_mbuf.c,v 1.236 2019/12/06 07:27:07 maxv Exp $	*/
 
 /*
  * Copyright (c) 1999, 2001, 2018 The NetBSD Foundation, Inc.
@@ -62,7 +62,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_mbuf.c,v 1.235 2019/10/19 06:36:47 tnn Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_mbuf.c,v 1.236 2019/12/06 07:27:07 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_mbuftrace.h"
@@ -2205,7 +2205,7 @@ m_verify_packet(struct mbuf *m)
 
 		dat = n->m_data;
 		len = n->m_len;
-		if (__predict_false(dat + len < dat)) {
+		if (__predict_false(len < 0)) {
 			panic("%s: incorrect length (len = %d)", __func__, len);
 		}