CVS commit: src/sys

[Andrew Doran]

Module Name:    src
Committed By:   ad
Date:           Sun Dec  8 19:52:37 UTC 2019

Modified Files:
        src/sys/dev/qbus: ts.c
        src/sys/kern: kern_physio.c
        src/sys/ufs/lfs: lfs_segment.c

Log Message:
Revert previous.  No performance gain worth the potential headaches
with buffers in these contexts.


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/qbus/ts.c
cvs rdiff -u -r1.96 -r1.97 src/sys/kern/kern_physio.c
cvs rdiff -u -r1.279 -r1.280 src/sys/ufs/lfs/lfs_segment.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/sys/dev/qbus/ts.c
diff -u src/sys/dev/qbus/ts.c:1.32 src/sys/dev/qbus/ts.c:1.33
--- src/sys/dev/qbus/ts.c:1.32	Sun Dec  8 19:23:51 2019
+++ src/sys/dev/qbus/ts.c	Sun Dec  8 19:52:37 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: ts.c,v 1.32 2019/12/08 19:23:51 ad Exp $ */
+/*	$NetBSD: ts.c,v 1.33 2019/12/08 19:52:37 ad Exp $ */
 
 /*-
  * Copyright (c) 1991 The Regents of the University of California.
@@ -66,7 +66,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ts.c,v 1.32 2019/12/08 19:23:51 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ts.c,v 1.33 2019/12/08 19:52:37 ad Exp $");
 
 #undef	TSDEBUG
 
@@ -390,7 +390,7 @@ tscommand(struct ts_softc *sc, dev_t dev
 		return;
 	biowait(bp);
 	mutex_enter(&bufcache_lock);
-	cv_signal(&bp->b_busy);
+	cv_broadcast(&bp->b_busy);
 	bp->b_cflags = 0;
 	mutex_exit(&bufcache_lock);
 }

Index: src/sys/kern/kern_physio.c
diff -u src/sys/kern/kern_physio.c:1.96 src/sys/kern/kern_physio.c:1.97
--- src/sys/kern/kern_physio.c:1.96	Sun Dec  8 19:23:51 2019
+++ src/sys/kern/kern_physio.c	Sun Dec  8 19:52:37 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: kern_physio.c,v 1.96 2019/12/08 19:23:51 ad Exp $	*/
+/*	$NetBSD: kern_physio.c,v 1.97 2019/12/08 19:52:37 ad Exp $	*/
 
 /*-
  * Copyright (c) 1982, 1986, 1990, 1993
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_physio.c,v 1.96 2019/12/08 19:23:51 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_physio.c,v 1.97 2019/12/08 19:52:37 ad Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -432,7 +432,7 @@ done_locked:
 		obp->b_cflags &= ~(BC_BUSY | BC_WANTED);
 		obp->b_flags &= ~(B_PHYS | B_RAW);
 		obp->b_iodone = NULL;
-		cv_signal(&obp->b_busy);
+		cv_broadcast(&obp->b_busy);
 		mutex_exit(&bufcache_lock);
 	}
 

Index: src/sys/ufs/lfs/lfs_segment.c
diff -u src/sys/ufs/lfs/lfs_segment.c:1.279 src/sys/ufs/lfs/lfs_segment.c:1.280
--- src/sys/ufs/lfs/lfs_segment.c:1.279	Sun Dec  8 19:24:26 2019
+++ src/sys/ufs/lfs/lfs_segment.c	Sun Dec  8 19:52:37 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: lfs_segment.c,v 1.279 2019/12/08 19:24:26 ad Exp $	*/
+/*	$NetBSD: lfs_segment.c,v 1.280 2019/12/08 19:52:37 ad Exp $	*/
 
 /*-
  * Copyright (c) 1999, 2000, 2001, 2002, 2003 The NetBSD Foundation, Inc.
@@ -60,7 +60,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_segment.c,v 1.279 2019/12/08 19:24:26 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_segment.c,v 1.280 2019/12/08 19:52:37 ad Exp $");
 
 #ifdef DEBUG
 # define vndebug(vp, str) do {						\
@@ -2197,7 +2197,7 @@ lfs_writeseg(struct lfs *fs, struct segm
 		if (unbusybp != NULL) {
 			unbusybp->b_cflags &= ~BC_BUSY;
 			if (unbusybp->b_cflags & BC_WANTED)
-				cv_signal(&bp->b_busy);
+				cv_broadcast(&bp->b_busy);
 		}
 	}
 	mutex_exit(&bufcache_lock);