Module Name:    src
Committed By:   he
Date:           Mon Sep  1 16:31:17 UTC 2014

Modified Files:
        src/sys/ufs/chfs: chfs_readinode.c

Log Message:
Plug memory leak in a corner case in chfs_get_data_nodes().


To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/ufs/chfs/chfs_readinode.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/chfs/chfs_readinode.c
diff -u src/sys/ufs/chfs/chfs_readinode.c:1.8 src/sys/ufs/chfs/chfs_readinode.c:1.9
--- src/sys/ufs/chfs/chfs_readinode.c:1.8	Sun Oct 20 17:18:38 2013
+++ src/sys/ufs/chfs/chfs_readinode.c	Mon Sep  1 16:31:17 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: chfs_readinode.c,v 1.8 2013/10/20 17:18:38 christos Exp $	*/
+/*	$NetBSD: chfs_readinode.c,v 1.9 2014/09/01 16:31:17 he Exp $	*/
 
 /*-
  * Copyright (c) 2010 Department of Software Engineering,
@@ -801,8 +801,10 @@ chfs_get_data_nodes(struct chfs_mount *c
 	buf = kmem_alloc(len, KM_SLEEP);
 
 	dnode = kmem_alloc(len, KM_SLEEP);
-	if (!dnode)
+	if (!dnode) {
+		kmem_free(buf, len);
 		return ENOMEM;
+	}
 
 	nref = chfs_first_valid_data_ref(ip->chvc->dnode);
 

Reply via email to