Module Name:    src
Committed By:   he
Date:           Mon Sep  1 16:33:20 UTC 2014

Modified Files:
        src/sys/ufs/chfs: chfs_vnode.c

Log Message:
Plug memory leaks in error returns in chfs_readvnode().


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/ufs/chfs/chfs_vnode.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/chfs/chfs_vnode.c
diff -u src/sys/ufs/chfs/chfs_vnode.c:1.10 src/sys/ufs/chfs/chfs_vnode.c:1.11
--- src/sys/ufs/chfs/chfs_vnode.c:1.10	Thu Jan 23 10:13:57 2014
+++ src/sys/ufs/chfs/chfs_vnode.c	Mon Sep  1 16:33:20 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: chfs_vnode.c,v 1.10 2014/01/23 10:13:57 hannken Exp $	*/
+/*	$NetBSD: chfs_vnode.c,v 1.11 2014/09/01 16:33:20 he Exp $	*/
 
 /*-
  * Copyright (c) 2010 Department of Software Engineering,
@@ -94,11 +94,14 @@ chfs_readvnode(struct mount *mp, ino_t i
 		buf = kmem_alloc(len, KM_SLEEP);
 		err = chfs_read_leb(chmp, chvc->v->nref_lnr, buf,
 		    CHFS_GET_OFS(chvc->v->nref_offset), len, &retlen);
-		if (err)
+		if (err) {
+			kmem_free(buf, len);
 			return err;
+		}
 		if (retlen != len) {
 			chfs_err("Error reading vnode: read: %zu insted of: %zu\n",
 			    len, retlen);
+			kmem_free(buf, len);
 			return EIO;
 		}
 		chfvn = (struct chfs_flash_vnode*)buf;

Reply via email to