Mike,

Why do we need XMLRPCInvoker interface?
https://fedorahosted.org/spacewalk/browser/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/XMLRPCInvoker.java

Can we move XMLRPCHelper out of the kickstart.cobbler package? Seems it could be
useful for other things not just cobbler or kickstart, with one minor change:
the ctor would have to taking the server url of the XML-RPC server vs calling
getCobblerServerUrl() method.

Also, why not call the method invoke instead of invokeXMLRPC. The
class is called
XMLRPCHelper, so presumably invoke is for XMLRPC. Alternatively,
invokeProcedure, invokeMethod, invokeCall, something like that because
XMLRPC is a protocol
so invokeing a protocol doesn't make much sense :)

https://fedorahosted.org/spacewalk/browser/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/XMLRPCHelper.java

jesus

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to