Jesus M. Rodriguez wrote:
Mike,
Why do we need XMLRPCInvoker interface?
it is actually an interface that I wanted to use to provide a real and a
mock interface to implement for testing purposes. This was so we could
have the JUnits calling a mock implementation vs having to call cobbler...
https://fedorahosted.org/spacewalk/browser/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/XMLRPCInvoker.java
Can we move XMLRPCHelper out of the kickstart.cobbler package? Seems it could be
useful for other things not just cobbler or kickstart, with one minor change:
the ctor would have to taking the server url of the XML-RPC server vs calling
getCobblerServerUrl() method.
Sure.
Also, why not call the method invoke instead of invokeXMLRPC. The
class is called
XMLRPCHelper, so presumably invoke is for XMLRPC. Alternatively,
invokeProcedure, invokeMethod, invokeCall, something like that because
XMLRPC is a protocol
so invokeing a protocol doesn't make much sense :)
Will switch to invokeMethod().
thanks!
--
Mike McCune
mmccune AT redhat.com
Engineering | Portland, OR
RHN Satellite | 650.567.9039x79248
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
