On Tuesday 11 of September 2012 17:28:34 Johannes Renner wrote: > On 09/11/2012 01:32 PM, Tomas Lestach wrote: > > On Monday 10 of September 2012 11:36:49 Johannes Renner wrote: > >> Hey, > >> > >> Here is a patch for adding some validation to the HTTP proxy field on the > >> general config page > >> (https://<hostname>/rhn/admin/config/GeneralConfig.do). > >> > >> This validator will allow FQDN or FQDN:port only, while a simple hostname > >> will not pass. IPv4 addresses will pass, but IPv6 won't. > > > > What is the reason for not matching IPv6 addresses? > > As we work on IPv6 support, this looks like a regression to me. > > The reason is that we are not sure if the tools picking up the address from > rhn.conf will actually be able to handle IPv6. Especially when using the > [...]:port notation where the address is given in brackets: Curl e.g. was > very recently still not able to handle adresses given in that notation. So > we wanted to allow only notations where we know that it will actually work > with. >
I see. > If you successfully tested this with an IPv6 based proxy and it works we can > allow those addresses as well of course. I am not aware of any bugzilla reporting it wouldn't work. So, I suppose it does. > Also it will still be possible to > put a hostname that will resolve to an IPv6 address. Further, the comment > in rhn.conf says > > # Use proxy FQDN, or FQDN:port > > which means even IPv4 addresses should not be allowed. That's correct. Let's hope, it's because of historical reasons. :-) Anyway, please, suppose Spacewalk is IPv6 ready, so if you allow IPv4 addresses, please allow IPv6 addresses as well. In case it turns out something doesn't work as expected, we'd face the issue. I'll be happy to commit your patch, when it allows also IPv6 addresses. > > >> Feel free to > >> propose changes, this can be done in many different ways. I just went for > >> an easy approach that reuses some existing and tested code, but we can > >> also > >> use a regex if you prefer that. > >> > >> BTW: Does anybody know why all error messages on that particular page > >> keep > >> on appearing twice? Or it's not the case for you? I might look after this > >> bug as well.. > > > > Possible. > > If you won't find any time to check the reason, could you, please, file a > > Spacewalk BZ (with me as assignee), please? > > I will do that for now, since I am currently busy with other things as well. Thanks. > > Thanks, > Johannes Regards, -- Tomas Lestach RHN Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
