On Friday 14 of September 2012 11:36:40 Johannes Renner wrote: > On 09/12/2012 05:51 PM, Tomas Lestach wrote: > [...] > > > Anyway, please, suppose Spacewalk is IPv6 ready, so if you allow IPv4 > > addresses, please allow IPv6 addresses as well. > > In case it turns out something doesn't work as expected, we'd face the > > issue. > > > > I'll be happy to commit your patch, when it allows also IPv6 addresses. > > Ok, so here is a new implementation of the validator supporting IPv6 > addresses as well. Please take a look at the unit tests to see how it will > behave. > > The algorithm is similar to the one in [1] (see the fromString() method > there) and the BRACKET_PATTERN is taken from there as well. Do you think we > need to put a reference or something? > > Otherwise if you are satisfied with this one we might want to use it on > other pages as well, like e.g. the client HTTP proxy here: > > - https://<hostname>/rhn/admin/config/BootstrapConfig.do > > Regards, > Johannes > > [1] > https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google > /common/net/HostAndPort.java
Hi Johannes, the patch look good. However looking at [1] I see the code is licensed under the Apache License, Version 2.0. I'm afraid this version isn't compatible with the Spacewalk's GPLv2. Or is it? Cliff? Tomas -- Tomas Lestach RHN Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
