Hello Duncan, I wasn't able to apply your patch. Could you send your patch rebased on latest master? Or at least write me against what commit I shall apply it. It seems that java/code/webapp/WEB-INF/includes/header.jsp version against that the patch is done, was never in Spacewalk.
Please create your patch using: git format-patch Btw. do you plan to apply the bootstrap framework to perl pages as they are? Thank you, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat ----- Original Message ----- > From: "Duncan Mac-Vicar P." <dmacvi...@suse.de> > To: "spacewalk-devel" <spacewalk-devel@redhat.com> > Sent: Thursday, July 25, 2013 7:00:15 PM > Subject: [Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS > framework? > > > Hey astronauts > > Twitter bootstrap (http://twitter.github.io/bootstrap/) is a CSS > framework that in addition to provide a good looking "default" theme, > it > also provides: > > - A very simple and standardized way of building the UI, with > provided > styles for common UI elements > - Grid, Javascript plugins/features, typography, forms > - Awesome documentation (see the website) > - Responsive design > - Font icons (with Glyph-icons or Font-Awesome) > - So popular that apart of good docs there is a big community around > - It works with LESS, which makes reusing and customizing CSS very > easy > - It has explicit instructions on how to customize it. > > We find Bootstrap a very attractive path to: > > - Cleanup the markup and move it to the current state of the art > - Make it very defined an easier for RHN and SUSE Manager to be a > customized version of Spacewalk. > - Have a better toolkit at hand for doing new user interfaces and/or > optional modules. > > We started to explore how it would look to change the CSS framework. > At > the end it resulted not that complicated, as once you set the > framework, > lot of the UI is generated in Java code and custom tags, which have > the > styles hard-coded. > > So I did an initial port (See patch attached). Mostly the base layout > and the tags. There are a lot of jsp pages with plain html that need > porting by hand, but hey, it is a good start. > > Here is a gallery with Spacewalk being customized by just changing a > LESS [²] file with variables (similar to what > http://twitter.github.io/bootstrap/customize.html#variables offers): > > http://postimg.org/gallery/7dwszo2g/35f216dc/ > > So of course this patch needs the 80% remaining work. The SUSE > Manager > team would be willing to do this work if upstream is willing to merge > it > [¹]. > > As 2.0 was just released, this may be a good timing to merge new > stuff. > > If this is accepted we could start working in a final patch in order > to > merge it some months from now. > > What do you think? > Other ideas? > > Regards, > > [¹] (we may still move forward with it at cost of a bigger fork, and > we > really want to make a decision soon to base future work on this). > > [²] http://lesscss.org, works precompiled (compiling to css at build > time) or at runtime with a javascript implementation (eg. for > development). There is a java > implementation as well: http://www.asual.com/lesscss > > -- > Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, > GF: > Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) > Maxfeldstraße 5, 90409 Nürnberg, Germany > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
