Hello Johannes, 

thank you for the patches!
I committed them as:
 4691d28da8edd4b2269f0c13551b28a1b4dd995c
 07cf3de71a85b08894ae68ae6a40f11454cd3846
 672bbc0756ccf588adbaf30e1102c289475dbe7f

Possible future enhancement - we could extend the CSV tag with the separator 
option, so the user may choose the separator for every single CSV Download (and 
optionally store the last used value as user default).

Regards,
--
Tomas Lestach
Red Hat Satellite Engineering, Red Hat


----- Original Message -----
> From: "Johannes Renner" <jren...@suse.de>
> To: spacewalk-devel@redhat.com
> Sent: Monday, August 19, 2013 2:21:30 PM
> Subject: [Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable
> 
> Hey,
> 
> here is a small feature patch that allows users to choose semicolon
> (";") as an
> alternative to comma (",") for the delimiter in all downloadable CSV
> files that
> we generate from the webapp. This seems to be helpful for importing
> those files
> into MS Excel for example.
> 
> Unfortunately we had to hack the schema source sanity check in order
> to not
> complain about a ";" in the middle of a table definition.
> 
> I hope you like the idea and the patch as well, let me know what you
> think.
> 
> Thanks,
> Johannes
> 
> --
> SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
> 
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to