On 1/30/14, 3:57 AM, "Matej Kollar" <mkol...@redhat.com> wrote:
>Hi all. > >We welcome community contributions and we want to maintain some level >of quality. Natural expectation is that every proposed patch is >tested for the functionality. > >However, recently I came across quite nasty little thing in Spacewalk... > >Using SSM to schedule reboot one might end up very unpleasantly surprised, >expecting it not to occur for specified period of time, when in fact it >is being scheduled "as soon as possible", no matter what you try. > >(There was no way it ever worked - parameters for forms were not passed >to script in request (where DatePicker looks for them) and new Date >object was returned. Well, someone scamped his work, so I had to do it >for him last night. And I consider myself lucky that I found out... >As en exercise in applied imagination, try to imagine OSAD running on >such machine. To stretch your imagination even further, imagine >the machine acting as a life supporting computer during child surgery...) Nice example :) . FYI, around here (Intermountain Healthcare), any activity requiring a planned reboot of a server would also require an SA to be on “live” and monitoring the system and would likely involve a DBA or App Admin to be online to confirm all services are properly started/running. Therefore, this example, while great, wouldn’t happen in our industry because we would never use such functionality (yes, mistakes can happen). BTW, there are systems that can directly impact patient care in general bed space, ICU, NICU, ED, OR and other facilities. So this example is an excellent idea in general to keep in mind. Yes, most systems in the world will not cause harm to life, limb or property should something go wrong, but there are a lot of places where it could (not just health care, but think about Air Traffic Control, City-wide Traffic Management, National Weather Service, Automated Industrial/Manufacturing and the list could go on and on). In the other end of the scale, what if something went sideways in a small company? People with 10 servers to manage or 100 servers and 5 employees can go out of business if their stuff is down/broken (by systems management software, like Spacewalk?). That’s a huge impact to their worlds. >Btw: next time have a peek into struts-config.xml and look for >form-bean and form-property tags... say like in >eea3c6320bfc3dae8532844a7c0e71dcc5712c39. > >To continue with our story: Purpose of that form is to schedule action >to occur "not sooner than". It fails on all but one particular case. It >simply cold not have been tested. > >Reboot is considered destructive operation. Therefore we insisted on >two-step scheduling for this feature. I fixed this one but wonder >how many other similar features there were recently introduced. > >And the final rhetorical question: Have the author even tried it >before submitting the patch? I tend to doubt it. > >Matej > >_______________________________________________ >Spacewalk-devel mailing list >Spacewalk-devel@redhat.com >https://www.redhat.com/mailman/listinfo/spacewalk-devel Thanks! Keep up the great work. -- Lamont Peterson Sr. Systems Administrator | Unix Systems Operations Intermountain Healthcare Office: 801.442.6497 _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
