http://bugzilla.spamassassin.org/show_bug.cgi?id=3483
------- Additional Comments From [EMAIL PROTECTED] 2004-07-14 12:46 ------- Subject: Re: [review] bayes _journal not syncing to _toks On Wed, Jul 14, 2004 at 11:36:27AM -0700, [EMAIL PROTECTED] wrote: > i may be wrong here.. but it looks like there is still problems with _journal > syncing to _toks even now that $self->opportunistic_calls(); is in skip: > section. Heh. Now that you bring it up... It's kind of obvious. <sigh> is_scan_available() unties if scan isn't available, which makes the opportunistic calls abort because they need the db in a readble, at least, state. I'll send up a patch in a minute, but from what I'm seeing... is_scan_available() is only called from 2 places. 1) PerMsgStatus::check() and M::SA::signal_user_change() and init(), which uses it to jump to scoreset+2 if bayes is available but the scoreset isn't set right. 2) Bayes::scan() to see if it needs to skip. So an easy solution would be to pass a parameter to is_scan_available() saying whether or not to untie. In the case of #2, scan() will untie() no matter what so is_scan_available() doesn't need to. From what I can tell, #1 can call is_scan_available() and then not do the untie() if, for instance, "use_bayes 0" occurs. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
