http://bugzilla.spamassassin.org/show_bug.cgi?id=3674
------- Additional Comments From [EMAIL PROTECTED] 2004-08-10 11:27 -------
Subject: Re: [review] 'ifversion' command
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> -1 I don't want to have a bunch of "iffoo" options, let's just have one
> "if (expression)" and one "endif" similar to the C preprocessor with
> several defined variables like version. Fixing this after 3.0.0 will
> be harder.
"ifplugin" has been in there for months. as far as I know, there's
distributed code on the web (SURBL at least, if I recall correctly)
that uses it.
Are you sure you want to change that now?
> Also, for this one, I'm not really sure that I like this particular
> regular expression-based way of untainting things. I'd prefer something
> more like:
>
> - split on whitespace
> - check value of each non-whitespace token against a more strict regexp
> && or || or ...
> - assemble logical expression
perl logical expressions don't need to include whitespace:
($version>1.00)
- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFBGRN6QTcbUG5Y7woRAp2HAKDmTONyFSfc58QBqyPBnyCawCqLcgCgjndF
6K2LNemVdOnHi2VQwkCxQUo=
=Bmva
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
