http://bugzilla.spamassassin.org/show_bug.cgi?id=3674
------- Additional Comments From [EMAIL PROTECTED] 2004-08-10 11:51 ------- Subject: Re: [review] 'ifversion' command On Tue, Aug 10, 2004 at 11:27:14AM -0700, [EMAIL PROTECTED] wrote: > > -1 I don't want to have a bunch of "iffoo" options, let's just have one > > "if (expression)" and one "endif" similar to the C preprocessor with > > several defined variables like version. Fixing this after 3.0.0 will > > be harder. > > "ifplugin" has been in there for months. as far as I know, there's > distributed code on the web (SURBL at least, if I recall correctly) > that uses it. > > Are you sure you want to change that now? I agree with quinlan that I'd rather have "if plugin M::SA::foo && version >= 3.0". It's generic, and allows for things like a plugin that works for 3.1 (assume we change the API) but not for 3.0, etc. However, yeah, ifplugin is the current API, and we shouldn't change it now when we're about ready to put out rc1 (we'd be closer if we stop moving tickets into the 3.0 queue...) I'd probably change the API to really be the "if plugin ..." bit, and add in a backward compat thing that "ifplugin" => "if plugin" internally. > perl logical expressions don't need to include whitespace: > > ($version>1.00) We should use/abuse the code we already have for the meta rules. It handles all this stuff. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
