http://bugzilla.spamassassin.org/show_bug.cgi?id=3715





------- Additional Comments From [EMAIL PROTECTED]  2004-08-23 10:15 -------
+0.9, two issues: 
 
1. Why is there a string compare via eq done instead of ==?  Both $ret and 
$INVALID_VALUE should be numbers and the string compare needs a "cast" of the 
numeric value to string first. 
 
2. I guess this one falls under "big API change for which its too late" ;)  But 
I don't like the fact that the success return value for the $cmd->{code}s is 
obviously undef.  That should be either 1 or something like $VALID_VALUE (== 
1); maybe <=0 -> error and >=1 -> success. 
 
btw, if I write +0.9 it means as much as "feel free to round this to +1 and 
commit, I just have some nitpicking issues with the code" :) 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to