http://bugzilla.spamassassin.org/show_bug.cgi?id=3715
------- Additional Comments From [EMAIL PROTECTED] 2004-08-23 10:22 ------- Subject: Re: [review] Conf::Parser double counts certain errors, etc. On Mon, Aug 23, 2004 at 10:15:36AM -0700, [EMAIL PROTECTED] wrote: > 1. Why is there a string compare via eq done instead of ==? Both $ret and > $INVALID_VALUE should be numbers and the string compare needs a "cast" of the > numeric value to string first. Because the return value, currently, can be anything, not just a number. For instance, the hash_key return value is either a key=>value pair or a number (for invalid/missing). Some things return undef, some things return strings, etc. > 2. I guess this one falls under "big API change for which its too late" ;) > But > I don't like the fact that the success return value for the $cmd->{code}s is > obviously undef. That should be either 1 or something like $VALID_VALUE (== > 1); maybe <=0 -> error and >=1 -> success. Yeah, I was thinking about that as I went through for the first patch. Hence my comment above the code call. It should be a bit better defined, but yeah, that'll be 3.1 I think. It requires modifying large chunks of code in Conf/Conf::Parser to return numbers only and not undef anywhere.... ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.