Hi,

It seems there is no interest in my patch to fix search on Chrome.
(see issue #723 two months ago and pull request #58 of three weeks ago)

I'm a bit at loss as to why. Is my patch flawed? Is this not relevant 
enough to fix? Is Sphinx a dead project?

Sorry for my questions. I'm happy to contribute to Sphinx, but if the 
project is dead, at least I know and can find an alternative.

Thanks a lot!
Freek


On Wednesday, 11 April 2012 19:24:55 UTC, Freek Dijkstra wrote:
>
> Hi,
>
> As have been discussed before [1][2][3][4], local search does not work
> in Google Chrome. The cause is that Google Chrome does not allow jQuery
> to load a file.
>
> I've submitted a very simple fix for this just over 3 weeks ago:
> https://bitbucket.org/birkenfeld/sphinx/issue/723/#comment-1204434
>
> In search.html, replace:
>
>     <script type="text/javascript">
>       jQuery(function() { Search.loadIndex("searchindex.js"); });
>     </script>
>
> with:
>
>     <script type="text/javascript" src="searchindex.js"></script>
>
> This is in fact how it worked in earlier versions of Sphinx. May I ask
> the maintainers to have a quick look, and if it works correctly, apply
> the patch?
>
> If there is another reason why the patch is not acceptable (e.g. you
> like a diff-based patch, it does not work or there is a good reason to
> keep the jQuery format), please do let me know and I can see if I can
> improve it.
>
> Thanks,
> Freek
>
> [1] https://groups.google.com/d/topic/sphinx-dev/GaDhOTfrOWg/discussion
> [2] https://bitbucket.org/birkenfeld/sphinx/issue/505/
> [3] https://bitbucket.org/birkenfeld/sphinx/issue/723/
> [4] https://bitbucket.org/birkenfeld/sphinx/issue/782/
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sphinx-dev" group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/sphinx-dev/-/byCKUI5mAXcJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sphinx-dev?hl=en.

Reply via email to