Wolfram Sang <[email protected]> wrote:

> Minor: I'd prefer spaces around the '='.
Done.

> I'd drop the comments. GPIO controllers may have private xlate-functions, so
> '1' could theoretically mean something else than "low-active" (although in
> practice it hopefully won't).

I dropped the polarity stuff. The "reg =" comment seems important
to me, I had to find this out by grep'ing and looking at the 
SPI master sourcecode. 
Patch V2 will be reposted.

Regards
Ernst

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to