On Sat, Mar 17, 2012 at 12:39 AM, Guennadi Liakhovetski <[email protected]> wrote:
> The SPI subsystem core now manages message queues internally. Remove the > local message queue implementation from the spi-bitbang driver and > migrate to the common one. > > Signed-off-by: Guennadi Liakhovetski <[email protected]> This is great stuff! Acked-by: Linus Walleij <[email protected]> (Since I've never really used the bitbang driver I wouldn't trust me to do any deeper review.) Quick thought: > +static int spi_bitbang_dummy_prepare(struct spi_master *master) > +{ > + return 0; (...) > + master->prepare_transfer_hardware = spi_bitbang_dummy_prepare; > + master->unprepare_transfer_hardware = spi_bitbang_dummy_prepare; Maybe we should think about making these two hooks optional if this pattern turns up a lot. I'll try to fix some refactoring further down the road if nobody beats me to it. Yours, Linus Walleij ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
