Dear Trent Piepho,
> Despite many warnings in the SPI documentation and code, the spi-mxs
> driver sets shared chip registers in the ->setup method. This method can
> be called when transfers are in progress on other slaves controlled by the
> master. Setting registers or any other shared state will corrupt those
> transfers.
>
> So fix mxs_spi_setup() to not call mxs_spi_setup_transfer().
>
> Signed-off-by: Trent Piepho <tpie...@gmail.com>
> Cc: Marek Vasut <ma...@denx.de>
> Cc: Fabio Estevam <fabio.este...@freescale.com>
> Cc: Shawn Guo <shawn....@linaro.org>
> ---
> drivers/spi/spi-mxs.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> index 103c478..2a2147a 100644
> --- a/drivers/spi/spi-mxs.c
> +++ b/drivers/spi/spi-mxs.c
> @@ -115,21 +115,16 @@ static int mxs_spi_setup_transfer(struct spi_device
> *dev,
>
> static int mxs_spi_setup(struct spi_device *dev)
> {
> - int err = 0;
> -
> if (!dev->bits_per_word)
> dev->bits_per_word = 8;
>
> if (dev->mode & ~(SPI_CPOL | SPI_CPHA))
> return -EINVAL;
>
> - err = mxs_spi_setup_transfer(dev, NULL);
> - if (err) {
> - dev_err(&dev->dev,
> - "Failed to setup transfer, error = %d\n", err);
> - }
> + if (dev->bits_per_word != 8)
> + return -EINVAL;
What's this new addition doing here?
btw. I was under the impression the MXS SSP block can handle other word-widths
than 8 bit, no ?
Best regards,
Marek Vasut
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
