>
> Hello,
> > diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
> > index 38c2b92..222e49e 100644
> > --- a/include/linux/spi/spi.h
> > +++ b/include/linux/spi/spi.h
> > @@ -437,6 +441,8 @@ extern struct spi_master
> > *spi_busnum_to_master(u16 busnum);
> > * @rx_buf: data to be read (dma-safe memory), or NULL
> > * @tx_dma: DMA address of tx_buf, if @spi_message.is_dma_mapped
> > * @rx_dma: DMA address of rx_buf, if @spi_message.is_dma_mapped
> > + * @tx_nbits: number of bits used for writting
> > + * @rx_nbits: number of bits used for reading
> > * @len: size of rx and tx buffers (in bytes)
> > * @speed_hz: Select a speed other than the device default for this
> > * transfer. If 0 the default (from @spi_device) is used.
> > @@ -491,6 +497,11 @@ extern struct spi_master
> > *spi_busnum_to_master(u16 busnum);
> > * by the results of previous messages and where the whole transaction
> > * ends when the chipselect goes intactive.
> > *
> > + * When SPI can transfer in 1x,2x or 4x. It can get this tranfer
> > information
> > + * from device through @tx_nbits and @rx_nbits. In Bi-direction, these
> > + * two should both be set. User can set transfer mode with
> > SPI_NBITS_SINGLE(1x)
> > + * SPI_NBITS_DUAL(2x) and SPI_NBITS_QUAD(4x) to support these three
> > transfer.
> > + *
> > * The code that submits an spi_message (and its spi_transfers)
> > * to the lower layers is responsible for managing its memory.
> > * Zero-initialize every field you don't set up explicitly, to
> > @@ -511,6 +522,11 @@ struct spi_transfer {
> > dma_addr_t rx_dma;
> >
> > unsigned cs_change:1;
> > + u8 tx_nbits;
> > + u8 rx_nbits;
> > +#define SPI_NBITS_SINGLE 0x0; /* 1bit transfer */
> > +#define SPI_NBITS_DUAL 0x01; /* 2bits transfer */
> > +#define SPI_NBITS_QUAD 0x02; /* 4bits transfer */
>
> [Pekon]: I don't think it's a good place for #defines. Plz keep it out of
> struct
> body.
One more feedback, Its better you define SPI_NBITS_xx matching
the actual number of wires used. This would leave places for some
micro-wire and 3-wire SPI, and would be more readable.
+#define SPI_NBITS_SINGLE_HALF_DUPLEX 0x0; /* 1bit transfer
microwire*/
+#define SPI_NBITS_SINGLE_FULL_DUPLEX 0x01; /* 1bit transfer normal
SPI*/
+#define SPI_NBITS_DUAL 2; /* 2bits transfer */
+#define SPI_NBITS_QUAD 4; /* 4bits transfer */
with regards, pekon
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
