> 2. I don't think that SPI_NBITS_SINGLE_HALF_DUPLEX is necessary. > tx_nbits and rx_nbits in @spi_transfer should be passed to spi master > driver and the master driver will set the certain mode depend on the > info in @spi_transfer. So there is no need to let the master driver > know SPI_NBITS_SINGLE_HALF_DUPLEX, also master can get the 3-wire SPI > info from spi_device->mode. I should have been more explicit here.. it would be good it you replace 'spi_device->mode & SPI_3_WIRE' with your above mode & tx_nbit, rx_nbits so that the channel width information becomes consistent for all modes. All mode bit flags in same octet look better.
with regards, pekon ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general