Thank you very much!

On 1/10/2012 11:47 AM, Michael Bayer wrote:
Code wasn't covered and is a regresssion, fixed in rd6e321dc120d.


On Jan 10, 2012, at 10:58 AM, Kent wrote:

Mike,

Old code:
==============================================
            def visit_bindparam(bindparam):
                if bindparam.key in bind_to_col:
                    bindparam.value = lambda:
mapper._get_state_attr_by_column(
                                            state, dict_,
bind_to_col[bindparam.key])
==============================================
New code (note that 'value' is now 'callable'):
            def visit_bindparam(bindparam):
                if bindparam._identifying_key in bind_to_col:
                    bindparam.callable = \
                            lambda: mapper._get_state_attr_by_column(
                                    state, dict_,

bind_to_col[bindparam._identifying_key])
==============================================

Now look at sql.util.py:
==============================================
def bind_values(clause):
    v = []
    def visit_bindparam(bind):
        value = bind.value

        # evaluate callables
        if callable(value):
            value = value()

        v.append(value)

    visitors.traverse(clause, {}, {'bindparam':visit_bindparam})
    return v
==============================================

Aren't we missing this: ?

  if bind.callable:
    value = bind.callable()

I think this is why it isn't loading the way it used to.

--
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To post to this group, send email to sqlalchemy@googlegroups.com.
To unsubscribe from this group, send email to 
sqlalchemy+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sqlalchemy?hl=en.


--
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To post to this group, send email to sqlalchemy@googlegroups.com.
To unsubscribe from this group, send email to 
sqlalchemy+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sqlalchemy?hl=en.

Reply via email to